linux-kernel - Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jul 2021 08:19:08 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:     zhouzhouyi@...il.com, Josh Triplett <josh@...htriplett.org>,
        rostedt <rostedt@...dmis.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        "Joel Fernandes, Google" <joel@...lfernandes.org>,
        rcu <rcu@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE

On Tue, Jul 13, 2021 at 06:18:12AM -0700, Paul E. McKenney wrote:
> On Tue, Jul 13, 2021 at 09:09:04AM -0400, Mathieu Desnoyers wrote:
> > ----- On Jul 13, 2021, at 12:16 AM, paulmck paulmck@...nel.org wrote:
> > 
> > > On Tue, Jul 13, 2021 at 08:56:45AM +0800, zhouzhouyi@...il.com wrote:
> > >> From: Zhouyi Zhou <zhouzhouyi@...il.com>
> > >> 
> > >> Hi Paul,
> > >> 
> > >> During my studying of RCU, I did a grep in the kernel source tree.
> > >> I found there are 3 places where the macro name CONFIG_TASKS_RCU_TRACE
> > >> should be CONFIG_TASKS_TRACE_RCU instead.
> > >> 
> > >> Without memory fencing, the idle/userspace task inspection may not
> > >> be so accurate.
> > >> 
> > >> Thanks for your constant encouragement for my studying.
> > >> 
> > >> Best Wishes
> > >> Zhouyi
> > >> 
> > >> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
> > > 
> > > Good eyes, and those could cause real bugs, so thank you!
> > 
> > Hi Paul,
> > 
> > This makes me wonder: what is missing testing-wise in rcutorture to
> > catch those issues with testing before they reach mainline ?
> 
> My guess:  Running on weakly ordered architectures.  ;-)

And another guess:  A tool that identifies use of Kconfig options
that are not defined in any Kconfig* file.

							Thanx, Paul