linux-kernel - Re: [PATCH] perf tools: Fix build with libpfm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWG35oH+LdpkwoNrWaTDg9bZKxZoyH_vLbhYQnK8gd0RQ@mail.gmail.com>
Date:   Tue, 13 Jul 2021 13:11:34 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf tools: Fix build with libpfm

On Mon, Jul 12, 2021 at 4:49 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> It missed to update the parse_libpfm_events_option() to use a new
> helper function to set the event group leader.
>
>   $ make LIBPFM4=1
>   ...
>     CC      util/pfm.o
>   util/pfm.c: In function ‘parse_libpfm_events_option’:
>   util/pfm.c:103:9: error: ‘struct evsel’ has no member named ‘leader’
>     103 |    evsel->leader = grp_leader;
>         |         ^~
>   make[4]: *** [tools/build/Makefile.build:96: util/pfm.o] Error 1
>
> Fixes: fba7c86601e2 ("libperf: Move 'leader' from tools/perf to perf_evsel::leader")
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/pfm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pfm.c b/tools/perf/util/pfm.c
> index dd9ed56e0504..756295dedccc 100644
> --- a/tools/perf/util/pfm.c
> +++ b/tools/perf/util/pfm.c
> @@ -99,7 +99,7 @@ int parse_libpfm_events_option(const struct option *opt, const char *str,
>                         grp_leader = evsel;
>
>                 if (grp_evt > -1) {
> -                       evsel->leader = grp_leader;
> +                       evsel__set_leader(evsel, grp_leader);
>                         grp_leader->core.nr_members++;
>                         grp_evt++;
>                 }
> --
> 2.32.0.93.g670b81a890-goog
>