linux-kernel - Re: [PATCH v2] lsm_audit,selinux: return early for possible NULL audit buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhSd7hTXUyeYB1=icx+W40f4E=1fzp4AC3B2gHFeubArRg@mail.gmail.com>
Date:   Wed, 14 Jul 2021 15:26:37 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>,
        Ondrej Mosnacek <omosnace@...hat.com>, selinux@...r.kernel.org,
        linux-kernel@...r.kernel.org, austin.kim@....com,
        kernel-team@....com
Subject: Re: [PATCH v2] lsm_audit,selinux: return early for possible NULL
 audit buffers

On Tue, Jul 13, 2021 at 8:11 PM Austin Kim <austindh.kim@...il.com> wrote:
>
> From: Austin Kim <austin.kim@....com>
>
> audit_log_start() may return NULL in below cases:
>
>   - when audit is not initialized.
>   - when audit backlog limit exceeds.
>
> After the call to audit_log_start() is made and then possible NULL audit
> buffer argument is passed to audit_log_*() functions,
> audit_log_*() functions return immediately in case of a NULL audit buffer
> argument.
>
> But it is optimal to return early when audit_log_start() returns NULL,
> because it is not necessary for audit_log_*() functions to be called with
> NULL audit buffer argument.
>
> So add exception handling for possible NULL audit buffers where
> return value can be handled from callers.
>
> Signed-off-by: Austin Kim <austin.kim@....com>
> ---
>  security/selinux/hooks.c       | 4 ++++
>  security/selinux/ss/services.c | 2 ++
>  2 files changed, 6 insertions(+)

Merged into selinux/next, thank you!

-- 
paul moore
www.paul-moore.com