linux-kernel - Re: [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210714203843.GA3476672@robh.at.kernel.org>
Date:   Wed, 14 Jul 2021 14:38:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Emil Renner Berthing <kernel@...il.dk>,
        Sebastian Reichel <sre@...nel.org>,
        "Andrew F. Davis" <afd@...com>, devicetree@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional

On Tue, Jul 13, 2021 at 10:18:01AM +0100, Lee Jones wrote:
> On Sat, 26 Jun 2021, Emil Renner Berthing wrote:
> 
> > The BeagleV Starlight v0.9 board[1] doesn't have the IRQB line routed to
> > the SoC, but it is still useful to be able to reach the PMIC over I2C
> 
> What is still useful?
> 
> The GPIO and Regulator drivers?
> 
> > for the other functionality it provides.
> > 
> > [1] https://github.com/beagleboard/beaglev-starlight
> > 
> > Signed-off-by: Emil Renner Berthing <kernel@...il.dk>
> > ---
> >  .../devicetree/bindings/mfd/ti,tps65086.yaml  |  3 ---
> >  drivers/mfd/tps65086.c                        | 21 ++++++++++---------
> >  2 files changed, 11 insertions(+), 13 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > index ba638bd10a58..4b629fcc0df9 100644
> > --- a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > @@ -87,9 +87,6 @@ additionalProperties: false
> >  required:
> >    - compatible
> >    - reg
> > -  - interrupts
> > -  - interrupt-controller
> > -  - '#interrupt-cells'
> 
> I can't say that I've been keeping up with the latest DT binding
> changes, but shouldn't these lines be relocated into some kind of
> optional listing?
> 
> Or are optional properties omitted from documentation?

Optional properties are the ones not listed in the 'required' list.

Rob