linux-kernel - Re: [PATCH] mm: page_alloc: fix page_poison=1 / INIT_ON_ALLOC_DEFAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202107141413.78A4ED77@keescook>
Date:   Wed, 14 Jul 2021 14:14:04 -0700
From:   Kees Cook <keescook@...omium.org>
To:     bowsingbetee <bowsingbetee@...tonmail.com>
Cc:     Sergei Trofimovich <slyfox@...too.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Potapenko <glider@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] mm: page_alloc: fix page_poison=1 /
 INIT_ON_ALLOC_DEFAULT_ON interaction

On Wed, Jul 14, 2021 at 11:11:18AM +0000, bowsingbetee wrote:
> B & C variants show this message and A does not, which is what I would expect to happen.
> 
> Tested variants:
> 
> A. "page_poison=1 init_on_free=0 init_on_alloc=0 slub_debug=P"
> B. "page_poison=1 init_on_free=0 init_on_alloc=0 slub_debug=P init_on_free=1"
> C. "page_poison=1 slub_debug=P"
> 
> in common:
> CONFIG_INIT_ON_ALLOC_DEFAULT_ON=y
> CONFIG_INIT_ON_FREE_DEFAULT_ON=y
> CONFIG_PAGE_POISONING=y
> CONFIG_SLUB_DEBUG=y
> CONFIG_SLUB=y
> 
> (the slub parts don't matter, ignore them)
> 
> [...]
> 
> While both patches(Sergei's, and yours) work for me, I'll be using this one for now.
> 
> Thank you for your work!
> Cheers!

Awesome; thanks for testing it!

-Kees

-- 
Kees Cook