linux-kernel - Re: [PATCH] of: fdt: remove unnecessary codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210714225026.GA3683016@robh.at.kernel.org>
Date:   Wed, 14 Jul 2021 16:50:26 -0600
From:   Rob Herring <robh@...nel.org>
To:     권오훈 <ohoono.kwon@...sung.com>
Cc:     "frowand.list@...il.com" <frowand.list@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "ohkwon1043@...il.com" <ohkwon1043@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [PATCH] of: fdt: remove unnecessary codes

On Thu, 01 Jul 2021 23:04:57 +0900, 권오훈 wrote:
> While unflattening the device tree, we try to populate dt nodes and
> properties into tree-shaped data structure.
> 
> In populate_properties function, pprev is initially set to
> &np->properties, and then updated to &pp->next.
> 
> In both scenarios *pprev is NULL, since the memory area that we are
> allocating from is initially zeroed.
> 
> I tested the code as below, and it showed that BUG was never called.
> 
> -       if (!dryrun)
> +       if (!dryrun) {
> +               if (*pprev)
> +                       BUG();
>                 *pprev = NULL;
> +       }
> 
> Let's remove unnecessary code.
> 
> Signed-off-by: Ohhoon Kwon <ohoono.kwon@...sung.com>
> ---
>  drivers/of/fdt.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

Applied, thanks!