linux-kernel - Re: [smartpqi updates V2 PATCH 8/9] smartpqi: fix isr accessing uninitialized data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jul 2021 20:16:48 -0500
From:   John Donnelly <john.p.donnelly@...cle.com>
To:     Don Brace <don.brace@...rochip.com>, hch@...radead.org,
        martin.peterson@...cle.com, jejb@...ux.vnet.ibm.com,
        linux-scsi@...r.kernel.org
Cc:     Kevin.Barnett@...rochip.com, scott.teel@...rochip.com,
        Justin.Lindley@...rochip.com, scott.benesh@...rochip.com,
        gerry.morong@...rochip.com, mahesh.rajashekhara@...rochip.com,
        mike.mcgowen@...rochip.com, murthy.bhat@...rochip.com,
        balsundar.p@...rochip.com, joseph.szczypek@....com,
        jeff@...onical.com, POSWALD@...e.com, mwilck@...e.com,
        pmenzel@...gen.mpg.de, linux-kernel@...r.kernel.org
Subject: Re: [smartpqi updates V2 PATCH 8/9] smartpqi: fix isr accessing
 uninitialized data

On 7/13/21 4:02 PM, Don Brace wrote:
> From: Mike McGowen <mike.mcgowen@...rochip.com>
> 
> Correct driver's ISR accessing a data structure member
> that has not been fully initialized during driver
> initialization.
>    - The pqi queue groups can have uninitialized members
>      when an interrupt fires. This has not resulted in
>      any driver crashes. This was found during our own
>      internal testing. No bugs were ever filed.
> 
> Reviewed-by: Kevin Barnett <kevin.barnett@...rochip.com>
> Reviewed-by: Scott Benesh <scott.benesh@...rochip.com>
> Reviewed-by: Scott Teel <scott.teel@...rochip.com>
> Signed-off-by: Mike McGowen <mike.mcgowen@...rochip.com>
> Signed-off-by: Don Brace <don.brace@...rochip.com>


Acked-by : John Donnelly <john.p.donnelly@...cle.com>

> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index f0e84354f782..ab1c9c483478 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -7760,11 +7760,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info)
>   
>   	pqi_init_operational_queues(ctrl_info);
>   
> -	rc = pqi_request_irqs(ctrl_info);
> +	rc = pqi_create_queues(ctrl_info);
>   	if (rc)
>   		return rc;
>   
> -	rc = pqi_create_queues(ctrl_info);
> +	rc = pqi_request_irqs(ctrl_info);
>   	if (rc)
>   		return rc;
>   
>