linux-kernel - [PATCH -next] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jul 2021 16:39:03 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <virtualization@...ts.linux-foundation.org>
CC:     <kraxel@...hat.com>, <airlied@...ux.ie>, <daniel@...ll.ch>
Subject: [PATCH -next] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

Fix the missing pci_disable_device() before return
from bochs_pci_probe() in the error handling case.

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
 drivers/gpu/drm/tiny/bochs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index a2cfecfa8556..74832b9d3eae 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -666,6 +666,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent
 	return ret;
 
 err_free_dev:
+	pci_disable_device(pdev);
 	drm_dev_put(dev);
 	return ret;
 }
-- 
2.25.1