linux-kernel - Re: [PATCH v2] cacheinfo: clear cache_leaves(cpu) in free_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210714090353.6ncnqof74hwbx2gf@bogus>
Date:   Wed, 14 Jul 2021 10:03:53 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     james.morse@....com, gregkh@...uxfoundation.org, rafael@...nel.org,
        linux-kernel@...r.kernel.org, bobo.shaobowang@...wei.com,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v2] cacheinfo: clear cache_leaves(cpu) in
 free_cache_attributes()

On Wed, Jul 14, 2021 at 09:32:55AM +0800, Xiongfeng Wang wrote:
> On ARM64, when PPTT(Processor Properties Topology Table) is not
> implemented in ACPI boot, we will goto 'free_ci' with the following
> print:
>   Unable to detect cache hierarchy for CPU 0
>
> But some other codes may still use 'num_leaves' to iterate through the
> 'info_list', such as get_cpu_cacheinfo_id(). If 'info_list' is NULL , it
> would crash. So clear 'num_leaves' in free_cache_attributes().
>

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

--
Regards,
Sudeep