linux-kernel - Re: [patch 22/50] rbtree: Split out the rbtree type definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210714092416.GE2725@worktop.programming.kicks-ass.net>
Date:   Wed, 14 Jul 2021 11:24:16 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Davidlohr Bueso <dave@...olabs.net>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [patch 22/50] rbtree: Split out the rbtree type definitions

On Tue, Jul 13, 2021 at 05:11:16PM +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> 
> rtmutex.h needs the definition of struct rb_root_cached. rbtree.h includes
> kernel.h which includes spinlock.h. That works nicely for non-RT enabled
> kernels, but on RT enabled kernels spinlocks are based on rtmutexes which
> creates another circular header dependency as spinlocks.h will require
> rtmutex.h.
> 
> Split out the type definitions and move them into their own header file so
> the rtmutex header can include just those.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  include/linux/rbtree.h       | 30 +-----------------------------
>  include/linux/rbtree_types.h | 34 ++++++++++++++++++++++++++++++++++

This will mess up the tools/include/linux/ copy of these headers...