linux-kernel - Re: [PATCH] spi: spi-geni-qcom: Remove confusing comment about setting the watermark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YO65DHLzjIAV4P/D@matsya>
Date:   Wed, 14 Jul 2021 15:44:36 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Mark Brown <broonie@...nel.org>, akashast@...eaurora.org,
        swboyd@...omium.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: spi-geni-qcom: Remove confusing comment about
 setting the watermark

On 12-07-21, 08:50, Douglas Anderson wrote:
> The comment in setup_fifo_xfer() about setting the watermark wasn't
> quite proper grammar and also stopped making sense around commit
> 6d66507d9b55 ("spi: spi-geni-qcom: Don't wait to start 1st transfer if
> transmitting"). After that commit we actually start the transfer
> _before_ the watermark interrupt comes.
> 
> I don't think the comment really has any value anymore. We've already
> got a comment when we grab the spinlock saying that our interrupt can
> come any time as a result of the things in the locked section. Let's
> just remove it.

Reviewed-by: Vinod Koul <vkoul@...nel.org>

-- 
~Vinod