linux-kernel - Re: [PATCH 5.13 000/800] 5.13.2-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210714104119.GA30649@amd>
Date:   Wed, 14 Jul 2021 12:41:19 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Holger Kiehl <Holger.Kiehl@....de>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com, stable@...r.kernel.org
Subject: Re: [PATCH 5.13 000/800] 5.13.2-rc1 review

Hi!
> 
> > On 14. 07. 21, 10:15, Holger Kiehl wrote:
> > >> Yes, will try to do that. I think it will take some time ...
> > >>
> > > Hmm, I am doing something wrong?
> > 
> > No, you are not: -rcs are not tagged.
> > 
> > >     git clone
> > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >     linux-5.13.y
> > >     cd linux-5.13.y/
> > >     git tag|grep v5.13
> > >     v5.13
> > >     v5.13-rc1
> > >     v5.13-rc2
> > >     v5.13-rc3
> > >     v5.13-rc4
> > >     v5.13-rc5
> > >     v5.13-rc6
> > >     v5.13-rc7
> > >     v5.13.1
> > > 
> > > There is no v5.13.2-rc1. It is my first time with 'git bisect'. Must be
> > > doing something wrong. How can I get the correct git kernel rc version?
> > 
> > So just bisect v5.13.1..linux-5.13.y.
> > 
> But what do I say for bad?
> 
>    git bisect bad linux-5.13.y
>    error: Bad rev input: linux-5.13.y
> 
> Just saying:
> 
>    git bisect bad
>    git bisect good v5.13.1
>    Bisecting: a merge base must be tested
>    [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13
> 
> If I read this correctly it now set v5.13 as bad and v5.13.1 as good.
> How to set the correct bad?

You can use hashes instead of symbolic revisions, and that may be
easier. I suspect you want to say "git bisect bad
origin/linux-5.13.y". You can also just do git show and note the hash.

There's other option: git bisect can be quite confusing, but you are
searching for a bug in linear history, so you can just git log
--pretty=oneline into a file, then do the binary search
manually. Should be 10 steps or so...

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)