| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1626261483.14352.15.camel@mhfsdcap03>
Date: Wed, 14 Jul 2021 19:18:03 +0800
From: Yong Wu <yong.wu@...iatek.com>
To: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
CC: Matthias Brugger <matthias.bgg@...il.com>,
Joerg Roedel <joro@...tes.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
David Airlie <airlied@...ux.ie>,
"Mauro Carvalho Chehab" <mchehab@...nel.org>,
Evan Green <evgreen@...omium.org>,
Robin Murphy <robin.murphy@....com>,
Tomasz Figa <tfiga@...omium.org>,
"Will Deacon" <will.deacon@....com>,
<linux-mediatek@...ts.infradead.org>,
<srv_heupstream@...iatek.com>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<iommu@...ts.linux-foundation.org>, <youlin.pei@...iatek.com>,
Nicolas Boichat <drinkcat@...omium.org>,
Matthias Kaehlcke <mka@...omium.org>, <anan.sun@...iatek.com>,
<ming-fan.chen@...iatek.com>, <yi.kuo@...iatek.com>,
<acourbot@...omium.org>, <linux-media@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>, Daniel Vetter <daniel@...ll.ch>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Xia Jiang <xia.jiang@...iatek.com>,
Tiffany Lin <tiffany.lin@...iatek.com>,
Hsin-Yi Wang <hsinyi@...omium.org>,
"Eizan Miyamoto" <eizan@...omium.org>, <anthony.huang@...iatek.com>
Subject: Re: [PATCH v6 00/11] Clean up "mediatek,larb"
On Wed, 2021-07-14 at 10:56 +0200, Dafna Hirschfeld wrote:
> Hi
>
> Thanks for the patchset.
>
> I tested it on mt8173 (elm) with chromeos userspace.
> Before that patchset, the test:
>
> tast -verbose run -build=false 10.42.0.175 video.DecodeAccel.h264
>
> sometimes passed and sometimes failed with 'context deadline exceeded'.
> With this patchset it seems that the test always passes so I added tested-by:
>
> Tested-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
Thanks very much for your quick review and testing:)
>
> Thanks,
> Dafna
>
>
>
>
> On 14.07.21 04:56, Yong Wu wrote:
> > MediaTek IOMMU block diagram always like below:
> >
> > M4U
> > |
> > smi-common
> > |
> > -------------
> > | | ...
> > | |
> > larb1 larb2
> > | |
> > vdec venc
> >
> > All the consumer connect with smi-larb, then connect with smi-common.
> >
> > When the consumer works, it should enable the smi-larb's power which also
> > need enable the smi-common's power firstly.
> >
> > Thus, Firstly, use the device link connect the consumer and the
> > smi-larbs. then add device link between the smi-larb and smi-common.
> >
> > After adding the device_link, then "mediatek,larb" property can be removed.
> > the iommu consumer don't need call the mtk_smi_larb_get/put to enable
> > the power and clock of smi-larb and smi-common.
> >
> > About the MM dt-binding/dtsi patches, I guess they should go together, thus
> > I don't split them for each a MM module and each a SoC.
> >
> > Base on v5.14-rc1, and a jpeg[1] and mdp[2] patchset.
> >
> > [1] https://lore.kernel.org/linux-mediatek/20210702102304.3346429-1-hsinyi@chromium.org/
> > [2] https://lore.kernel.org/linux-mediatek/20210709022324.1607884-1-eizan@chromium.org/
> >
> > Change notes:
> > v6: 1) rebase on v5.14-rc1.
> > 2) Fix the issue commented in v5 from Dafna and Hsin-Yi.
> > 3) Remove the patches about using pm_runtime_resume_and_get since they have
> > already been merged by other patches.
> >
> > v5: https://lore.kernel.org/linux-mediatek/20210410091128.31823-1-yong.wu@mediatek.com/
> > 1) Base v5.12-rc2.
> > 2) Remove changing the mtk-iommu to module_platform_driver patch, It have already been a
> > independent patch.
> >
> > v4: https://lore.kernel.org/linux-mediatek/1590826218-23653-1-git-send-email-yong.wu@mediatek.com/
> > base on v5.7-rc1.
> > 1) Move drm PM patch before smi patchs.
> > 2) Change builtin_platform_driver to module_platform_driver since we may need
> > build as module.
> > 3) Rebase many patchset as above.
> >
> > v3: https://lore.kernel.org/linux-iommu/1567503456-24725-1-git-send-email-yong.wu@mediatek.com/
> > 1) rebase on v5.3-rc1 and the latest mt8183 patchset.
> > 2) Use device_is_bound to check whether the driver is ready from Matthias.
> > 3) Add DL_FLAG_STATELESS flag when calling device_link_add and explain the
> > reason in the commit message[3/14].
> > 4) Add a display patch[12/14] into this series. otherwise it may affect
> > display HW fastlogo even though it don't happen in mt8183.
> >
> > v2: https://lore.kernel.org/linux-iommu/1560171313-28299-1-git-send-email-yong.wu@mediatek.com/
> > 1) rebase on v5.2-rc1.
> > 2) Move adding device_link between the consumer and smi-larb into
> > iommu_add_device from Robin.
> > 3) add DL_FLAG_AUTOREMOVE_CONSUMER even though the smi is built-in from Evan.
> > 4) Remove the shutdown callback in iommu.
> >
> > v1: https://lore.kernel.org/linux-iommu/1546318276-18993-1-git-send-email-yong.wu@mediatek.com/
> >
> > Yong Wu (10):
> > dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW
> > iommu/mediatek: Add probe_defer for smi-larb
> > iommu/mediatek: Add device_link between the consumer and the larb
> > devices
> > media: mtk-jpeg: Get rid of mtk_smi_larb_get/put
> > media: mtk-mdp: Get rid of mtk_smi_larb_get/put
> > drm/mediatek: Get rid of mtk_smi_larb_get/put
> > media: mtk-vcodec: Get rid of mtk_smi_larb_get/put
> > memory: mtk-smi: Get rid of mtk_smi_larb_get/put
> > arm: dts: mediatek: Get rid of mediatek,larb for MM nodes
> > arm64: dts: mediatek: Get rid of mediatek,larb for MM nodes
> >
> > Yongqiang Niu (1):
> > drm/mediatek: Add pm runtime support for ovl and rdma
> >
> > .../display/mediatek/mediatek,disp.txt | 9 ----
> > .../bindings/media/mediatek-jpeg-decoder.yaml | 9 ----
> > .../bindings/media/mediatek-jpeg-encoder.yaml | 9 ----
> > .../bindings/media/mediatek-mdp.txt | 8 ----
> > .../bindings/media/mediatek-vcodec.txt | 4 --
> > arch/arm/boot/dts/mt2701.dtsi | 2 -
> > arch/arm/boot/dts/mt7623n.dtsi | 5 --
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 -------
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 6 ---
> > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 9 +++-
> > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 9 +++-
> > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 ++++----
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 36 +--------------
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 -
> > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +-
> > drivers/iommu/mtk_iommu.c | 24 +++++++++-
> > drivers/iommu/mtk_iommu_v1.c | 22 ++++++++-
> > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +-----------------
> > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 -
> > drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 46 +------------------
> > drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 -
> > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 1 -
> > .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 37 ++-------------
> > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 3 --
> > .../platform/mtk-vcodec/mtk_vcodec_enc.c | 1 -
> > .../platform/mtk-vcodec/mtk_vcodec_enc_pm.c | 44 ++----------------
> > drivers/memory/mtk-smi.c | 14 ------
> > include/soc/mediatek/smi.h | 20 --------
> > 28 files changed, 85 insertions(+), 323 deletions(-)
> >
Powered by blists - more mailing lists