linux-kernel - Re: [PATCH] kfence: defer kfence_test_init to ensure that kunit debugfs is created

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmjNMe+wyuFLJ0nOk-4Sr57GgBf6VuHa3hmsVUZYJ1gjuC5A@mail.gmail.com>
Date:   Wed, 14 Jul 2021 13:56:20 +0200
From:   Marco Elver <elver@...gle.com>
To:     Weizhao Ouyang <o451686892@...il.com>
Cc:     glider@...gle.com, dvyukov@...gle.com, akpm@...ux-foundation.org,
        kasan-dev@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kfence: defer kfence_test_init to ensure that kunit
 debugfs is created

On Wed, 14 Jul 2021 at 13:31, Weizhao Ouyang <o451686892@...il.com> wrote:
> kfence_test_init and kunit_init both use the same level late_initcall,
> which means if kfence_test_init linked ahead of kunit_init,
> kfence_test_init will get a NULL debugfs_rootdir as parent dentry,
> then kfence_test_init and kfence_debugfs_init both create a debugfs
> node named "kfence" under debugfs_mount->mnt_root, and it will throw
> out "debugfs: Directory 'kfence' with parent '/' already present!" with
> EEXIST. So kfence_test_init should be deferred.
>
> Signed-off-by: Weizhao Ouyang <o451686892@...il.com>

Tested-by: Marco Elver <elver@...gle.com>

Thank you.

> ---
>  mm/kfence/kfence_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
> index 7f24b9bcb2ec..942cbc16ad26 100644
> --- a/mm/kfence/kfence_test.c
> +++ b/mm/kfence/kfence_test.c
> @@ -852,7 +852,7 @@ static void kfence_test_exit(void)
>         tracepoint_synchronize_unregister();
>  }
>
> -late_initcall(kfence_test_init);
> +late_initcall_sync(kfence_test_init);
>  module_exit(kfence_test_exit);
>
>  MODULE_LICENSE("GPL v2");
> --
> 2.30.2