linux-kernel - Re: [PATCH v3 06/14] RDMA/irdma: Use irq_set_affinity_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YO7SiFE1dE0dFhkE@unreal>
Date:   Wed, 14 Jul 2021 15:03:20 +0300
From:   Leon Romanovsky <leonro@...dia.com>
To:     Nitesh Narayan Lal <nitesh@...hat.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
        <linux-api@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <tglx@...utronix.de>, <jesse.brandeburg@...el.com>,
        <robin.murphy@....com>, <mtosatti@...hat.com>, <mingo@...nel.org>,
        <jbrandeb@...nel.org>, <frederic@...nel.org>,
        <juri.lelli@...hat.com>, <abelits@...vell.com>,
        <bhelgaas@...gle.com>, <rostedt@...dmis.org>,
        <peterz@...radead.org>, <davem@...emloft.net>,
        <akpm@...ux-foundation.org>, <sfr@...b.auug.org.au>,
        <stephen@...workplumber.org>, <rppt@...ux.vnet.ibm.com>,
        <chris.friesen@...driver.com>, <maz@...nel.org>,
        <nhorman@...driver.com>, <pjwaskiewicz@...il.com>,
        <sassmann@...hat.com>, <thenzl@...hat.com>,
        <kashyap.desai@...adcom.com>, <sumit.saxena@...adcom.com>,
        <shivasharan.srikanteshwara@...adcom.com>,
        <sathya.prakash@...adcom.com>, <sreekanth.reddy@...adcom.com>,
        <suganath-prabu.subramani@...adcom.com>,
        <james.smart@...adcom.com>, <dick.kennedy@...adcom.com>,
        <jkc@...hat.com>, <faisal.latif@...el.com>,
        <shiraz.saleem@...el.com>, <tariqt@...dia.com>,
        <ahleihel@...hat.com>, <kheib@...hat.com>, <borisp@...dia.com>,
        <saeedm@...dia.com>, <benve@...co.com>, <govind@....com>,
        <jassisinghbrar@...il.com>, <ajit.khaparde@...adcom.com>,
        <sriharsha.basavapatna@...adcom.com>, <somnath.kotur@...adcom.com>,
        <nilal@...hat.com>, <tatyana.e.nikolova@...el.com>,
        <mustafa.ismail@...el.com>, <ahs3@...hat.com>,
        <chandrakanth.patil@...adcom.com>
Subject: Re: [PATCH v3 06/14] RDMA/irdma: Use irq_set_affinity_and_hint

On Tue, Jul 13, 2021 at 05:14:54PM -0400, Nitesh Narayan Lal wrote:
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask
> that is consumed by the userspace to distribute the interrupts and to apply
> the provided mask as the affinity for its interrupts. However,
> irq_set_affinity_hint() applying the provided cpumask as an affinity for
> the interrupt is an undocumented side effect.
> 
> To remove this side effect irq_set_affinity_hint() has been marked
> as deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
> where the provided mask needs to be applied as the affinity and
> affinity_hint pointer needs to be set and replace with
> irq_update_affinity_hint() where only affinity_hint needs to be updated.
> 
> Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com>
> ---
>  drivers/infiniband/hw/irdma/hw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
> index 7afb8a6a0526..7f13a051d4de 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
>  	struct irdma_sc_dev *dev = &rf->sc_dev;
>  
>  	dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
> -	irq_set_affinity_hint(msix_vec->irq, NULL);
> +	irq_update_affinity_hint(msix_vec->irq, NULL);
>  	free_irq(msix_vec->irq, dev_id);
>  }
>  
> @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq,
>  	}
>  	cpumask_clear(&msix_vec->mask);
>  	cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
> -	irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
> +	irq_set_affinity_and_hint(msix_vec->irq, &msix_vec->mask);

I think that it needs to be irq_update_affinity_hint().

>  	if (status) {
>  		ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n");
>  		return IRDMA_ERR_CFG;
> -- 
> 2.27.0
>