linux-kernel - Re: [PATCH -next] sched: Dec __cfs_bandwith_used in destroy_cfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210714132233.o4zvgdiiugxf6yxk@oracle.com>
Date:   Wed, 14 Jul 2021 09:22:33 -0400
From:   Daniel Jordan <daniel.m.jordan@...cle.com>
To:     20210712162655.w3j6uczwbfkzazvt@...cle.com
Cc:     bsegall@...gle.com, dietmar.eggemann@....com,
        juri.lelli@...hat.com, linux-kernel@...r.kernel.org,
        mingo@...hat.com, peterz@...radead.org, pjt@...gle.com,
        vincent.guittot@...aro.org, zhangqiao22@...wei.com
Subject: Re: [PATCH -next] sched: Dec __cfs_bandwith_used in
 destroy_cfs_bandwidth()

On Wed, Jul 14, 2021 at 07:20:39PM +0800, Zhang Qiao wrote:
> And i have another thought is that we can hold the
> hotplug lock before calling cfs_bandwidth_usage_dec().
> This way, fewer modifications are involved.
> What do you think about it?

It is fewer lines, but then hotplug lock is taken pointlessly for
!JUMP_LABEL.  Not a huge deal in a slow path like this, just a bit lame.
Adding a new variant seems cleaner if more verbose.