linux-kernel - Re: [RFC PATCH 1/1] sched: do active load balance in balance callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d9bfd3b-1b14-e741-de3b-9c9b30663b9d@arm.com>
Date:   Wed, 14 Jul 2021 16:18:30 +0200
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Valentin Schneider <valentin.schneider@....com>,
        Yafang Shao <laoar.shao@...il.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Benjamin Segall <bsegall@...gle.com>,
        Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/1] sched: do active load balance in balance callback

On 14/07/2021 14:27, Valentin Schneider wrote:
> On 11/07/21 15:40, Yafang Shao wrote:
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index 4ca80df205ce..a0a90a37e746 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -8208,6 +8208,7 @@ void __init sched_init(void)
>>                 rq->cpu_capacity = rq->cpu_capacity_orig = SCHED_CAPACITY_SCALE;
>>                 rq->balance_callback = &balance_push_callback;
>>                 rq->active_balance = 0;
>> +               rq->active_balance_target = NULL;
>>                 rq->next_balance = jiffies;
>>                 rq->push_cpu = 0;
>>                 rq->cpu = i;
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 23663318fb81..9aaa75250cdc 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -7751,36 +7751,6 @@ static void detach_task(struct task_struct *p,
>> struct lb_env *env)
> 
> Your mail client is breaking lines which pretty much wrecks the
> patch. Please use git send-email to submit patches, or look at
> Documentation/process/email-clients.rst to figure out how to tweak your
> client. 

Yeah, wasn't able to apply this patch either.