linux-kernel - Re: [PATCH v2] audit: fix memory leak in nf_tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD-N9QWmNYPkim_KrnUfvNhErUZaJqwGH-_3QvivVEvg+KnHjA@mail.gmail.com>
Date:   Wed, 14 Jul 2021 10:18:36 +0800
From:   Dongliang Mu <mudongliangabcd@...il.com>
To:     Florian Westphal <fw@...len.de>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Richard Guy Briggs <rgb@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        syzbot <syzkaller@...glegroups.com>,
        kernel test robot <lkp@...el.com>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] audit: fix memory leak in nf_tables_commit

On Tue, Jul 13, 2021 at 11:31 PM Florian Westphal <fw@...len.de> wrote:
>
> Dongliang Mu <mudongliangabcd@...il.com> wrote:
> > > > +static void nf_tables_commit_free(struct list_head *adl)
> > >
> > > nf_tables_commit_audit_free?
> >
> > What do you mean? Modify the name of newly added function to
> > nf_tables_commit_audit_free?
>
> Yes, this function is audit related, and it does the inverse
> of existing '...audit_alloc'.

Hi Florian,

I double-check the patch, and it seems there is no need to send a
followup patch (nf-next).

I will send a v3 patch with the new function name.

Best regards
Dongliang Mu