linux-kernel - Re: [PATCH 1/2] regulator: rtq6752: Add binding document for Richtek RTQ6752

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1626229151.3432.6.camel@richtek.com>
Date:   Wed, 14 Jul 2021 02:19:11 +0000
From:   cy_huang(黃啟原) <cy_huang@...htek.com>
To:     "robh@...nel.org" <robh@...nel.org>,
        "u0084500@...il.com" <u0084500@...il.com>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: rtq6752: Add binding document for Richtek
 RTQ6752

> On Fri, Jul 09, 2021 at 11:40:35PM +0800, cy_huang wrote:
> >
> > From: ChiYuan Huang <cy_huang@...htek.com>
> >
> > Add binding document for Richtek RTQ6752.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> > ---
> >  .../regulator/richtek,rtq6752-regulator.yaml       | 78
> > ++++++++++++++++++++++
> >  1 file changed, 78 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/regulator/richtek,rtq6752-regulator.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq6752-
> > regulator.yaml
> > b/Documentation/devicetree/bindings/regulator/richtek,rtq6752-regulator.yaml
> > new file mode 100644
> > index 00000000..641840e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq6752-
> > regulator.yaml
> > @@ -0,0 +1,78 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/richtek,rtq6752-regulator.yaml
> > #
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Richtek RTQ6752 TFT LCD Voltage Regulator
> > +
> > +maintainers:
> > +  - ChiYuan Huang <cy_huang@...htek.com>
> > +
> > +description: |
> > +  The RTQ6752 is an I2C interface pgorammable power management IC. It
> > includes
> > +  two synchronous boost converter for PAVDD, and one synchronous NAVDD
> > +  buck-boost. The device is suitable for automotive TFT-LCD panel.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - richtek,rtq6752
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  enable-gpios:
> > +    description: |
> > +      A connection of the chip 'enable' gpio line. If not provided, treat
> > it as
> > +      external pull up.
> > +    maxItems: 1
> > +
> > +  regulators:
> > +    type: object
> > +    $ref: regulator.yaml#
> This node is not a regulator, just a container. Drop.
>
Yes.
> >
> > +
> > +    patternProperties:
> > +      "^(p|n)avdd$":
> > +        type: object
> > +        $ref: regulator.yaml#
> > +        description: |
> > +          regulator description for pavdd and navdd.
> > +
> > +    additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - regulators
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      rtq6752@6b {
> > +        compatible = "richtek,rtq6752";
> > +        status = "okay";
> Don't show status in examples.
>
Okay.

I'll use one patch to update the above comment.
Thanks.
> >
> > +        reg = <0x6b>;
> > +        enable-gpios = <&gpio26 2 0>;
> > +
> > +        regulators {
> > +          pavdd {
> > +            regulator-name = "rtq6752-pavdd";
> > +            regulator-min-microvolt = <5000000>;
> > +            regulator-max-microvolt = <7300000>;
> > +            regulator-boot-on;
> > +          };
> > +          navdd {
> > +            regulator-name = "rtq6752-navdd";
> > +            regulator-min-microvolt = <5000000>;
> > +            regulator-max-microvolt = <7300000>;
> > +            regulator-boot-on;
> > +          };
> > +        };
> > +      };
> > +    };
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!