linux-kernel - Re: [PATCH] net: switchdev: Simplify 'mlxsw_sp_mc_write_mdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YO8HsWjq0Y1S08Uj@shredder>
Date:   Wed, 14 Jul 2021 18:50:09 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     jiri@...dia.com, idosch@...dia.com, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: switchdev: Simplify 'mlxsw_sp_mc_write_mdb_entry()'

On Wed, Jul 14, 2021 at 10:32:33AM +0200, Christophe JAILLET wrote:
> Use 'bitmap_alloc()/bitmap_free()' instead of hand-writing it.
> This makes the code less verbose.
> 
> Also, use 'bitmap_alloc()' instead of 'bitmap_zalloc()' because the bitmap
> is fully overridden by a 'bitmap_copy()' call just after its allocation.
> 
> While at it, remove an extra and unneeded space.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

For net-next:

Reviewed-by: Ido Schimmel <idosch@...dia.com>

Note that net-next is closed [1] so you might need to re-submit, if it
does not open soon.

Thanks for the patch.

[1] http://vger.kernel.org/~davem/net-next.html