linux-kernel - Re: [PATCH -next v2] sched: Dec cfs_bandwith_used in destroy_cfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210715202853.no4f7zylvwc5etfu@oracle.com>
Date:   Thu, 15 Jul 2021 16:28:53 -0400
From:   Daniel Jordan <daniel.m.jordan@...cle.com>
To:     Zhang Qiao <zhangqiao22@...wei.com>
Cc:     juri.lelli@...hat.com, linux-kernel@...r.kernel.org,
        mingo@...hat.com, peterz@...radead.org, pjt@...gle.com,
        vincent.guittot@...aro.org, daniel.m.jordan@...cle.com
Subject: Re: [PATCH -next v2] sched: Dec cfs_bandwith_used in
 destroy_cfs_bandwidth()

Only nits left from my side anyway.  Looks fine otherwise!

There are a couple typos in the subject and changelog, cfs_bandwith_used
and cfs_bandwith_uesd.

On Thu, Jul 15, 2021 at 07:24:33PM +0800, Zhang Qiao wrote:
> +
> +void cfs_bandwidth_usage_inc(void)
> +{
> +	static_key_slow_inc(&__cfs_bandwidth_used);
> +}

Nothing calls this, and getting rid of it would potentially avoid a
janitorial patch later.

> +void cfs_bandwidth_usage_dec(void)

   static void cfs_bandwidth_usage_dec(void)

>  void cfs_bandwidth_usage_inc(void) {}
>  void cfs_bandwidth_usage_dec(void) {}

   static void cfs_bandwidth_usage_dec(void) {}

> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
>  extern void cfs_bandwidth_usage_inc(void);
>  extern void cfs_bandwidth_usage_dec(void);

These would then go away.