linux-kernel - [PATCH] iommu: check if group is NULL before remove device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210715071043.82055-1-linux@fw-web.de>
Date:   Thu, 15 Jul 2021 09:10:43 +0200
From:   Frank Wunderlich <linux@...web.de>
To:     iommu@...ts.linux-foundation.org
Cc:     Frank Wunderlich <frank-w@...lic-files.de>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        linux-kernel@...r.kernel.org, yong.wu@...iatek.com
Subject: [PATCH] iommu: check if group is NULL before remove device

From: Frank Wunderlich <frank-w@...lic-files.de>

if probe is failing, iommu_group may be not initialized,
so freeing it will result in NULL pointer access

Fixes: d72e31c93746 ("iommu: IOMMU Groups")
Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
---
 drivers/iommu/iommu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 5419c4b9f27a..63f0af10c403 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -924,6 +924,9 @@ void iommu_group_remove_device(struct device *dev)
 	struct iommu_group *group = dev->iommu_group;
 	struct group_device *tmp_device, *device = NULL;
 
+	if (!group)
+		return;
+
 	dev_info(dev, "Removing from iommu group %d\n", group->id);
 
 	/* Pre-notify listeners that a device is being removed. */
-- 
2.25.1