linux-kernel - Re: [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7db5fbcd-3672-3a26-8b9f-bb01e3d3c3bd@redhat.com>
Date:   Thu, 15 Jul 2021 16:03:36 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Xie Yongji <xieyongji@...edance.com>, mst@...hat.com,
        dan.carpenter@...cle.com
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] vdpa_sim: Fix return value check for
 vdpa_alloc_device()


在 2021/7/15 下午3:59, Xie Yongji 写道:
> The vdpa_alloc_device() returns an error pointer upon
> failure, not NULL. To handle the failure correctly, this
> replaces NULL check with IS_ERR() check and propagate the
> error upwards.
>
> Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Xie Yongji <xieyongji@...edance.com>


Acked-by: Jason Wang <jasowang@...hat.com>


> ---
>   drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index 14e024de5cbf..c621cf7feec0 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
>   
>   	vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops,
>   				    dev_attr->name);
> -	if (!vdpasim)
> +	if (IS_ERR(vdpasim)) {
> +		ret = PTR_ERR(vdpasim);
>   		goto err_alloc;
> +	}
>   
>   	vdpasim->dev_attr = *dev_attr;
>   	INIT_WORK(&vdpasim->work, dev_attr->work_fn);