linux-kernel - [BUG] bus: mhi: possible ABBA deadlock in mhi_pm_m0_transition() and mhi_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Jul 2021 17:45:07 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     manivannan.sadhasivam@...aro.org, hemantk@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: [BUG] bus: mhi: possible ABBA deadlock in mhi_pm_m0_transition() and
 mhi_send_cmd()

Hello,

I find there is a possible ABBA deadlock in the MHI driver in Linux 5.10:

In mhi_pm_m0_transition():
262:     read_lock_bh(&mhi_cntrl->pm_lock);
281:     spin_lock_irq(&mhi_cmd->lock);

In mhi_send_cmd():
1181:   spin_lock_bh(&mhi_cmd->lock);
1207:   read_lock_bh(&mhi_cntrl->pm_lock);

When mhi_pm_m0_transition() and mhi_send_cmd() are concurrently 
executed, the deadlock can occur.

I check the code and find a possible case of such concurrent execution:

#CPU1:
mhi_poll (mhi_event->process_event(...))
   mhi_process_ctrl_ev_ring
     mhi_pm_m0_transition

#CPU2:
mhi_prepare_for_transfer
   mhi_prepare_channel
     mhi_send_cmd

Note that mhi_poll() and mhi_prepare_for_transfer() are both exported by 
EXPORT_SYMBOL.
Thus, I guess these two functions could be concurrently called by a MHI 
driver.

I am not quite sure whether this possible deadlock is real and how to 
fix it if it is real.
Any feedback would be appreciated, thanks :)

Best wishes,
Jia-Ju Bai