linux-kernel - Re: [PATCH 5.12] selftests/resctrl: Fix incorrect parsing of option "-t"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YPAShFw2BkuYYzlq@kroah.com>
Date:   Thu, 15 Jul 2021 12:48:36 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Xiaochen Shen <xiaochen.shen@...el.com>
Cc:     stable@...r.kernel.org, sashal@...nel.org, shuah@...nel.org,
        tony.luck@...el.com, fenghua.yu@...el.com,
        reinette.chatre@...el.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, pei.p.jia@...el.com
Subject: Re: [PATCH 5.12] selftests/resctrl: Fix incorrect parsing of option
 "-t"

On Mon, Jul 12, 2021 at 03:55:23PM +0800, Xiaochen Shen wrote:
> commit 1421ec684a43379b2aa3cfda20b03d38282dc990 upstream.
> 
> Resctrl test suite accepts command line argument "-t" to specify the
> unit tests to run in the test list (e.g., -t mbm,mba,cmt,cat) as
> documented in the help.
> 
> When calling strtok() to parse the option, the incorrect delimiters
> argument ":\t" is used. As a result, passing "-t mbm,mba,cmt,cat" throws
> an invalid option error.
> 
> Fix this by using delimiters argument "," instead of ":\t" for parsing
> of unit tests list. At the same time, remove the unnecessary "spaces"
> between the unit tests in help documentation to prevent confusion.
> 
> Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
> Fixes: 78941183d1b1 ("selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest")
> Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test")
> Fixes: 034c7678dd2c ("selftests/resctrl: Add README for resctrl tests")
> Cc: stable@...r.kernel.org
> Signed-off-by: Xiaochen Shen <xiaochen.shen@...el.com>
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
> ---
>  tools/testing/selftests/resctrl/README          | 2 +-
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 

Both now queued up, thanks.

greg k-h