linux-kernel - Re: [PATCH v2] net: dsa: mv88e6xxx: NET_DSA_MV88E6XXX_PTP should depend on NET_DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210715120129.comqj4lqiwcusj7q@skbuf>
Date:   Thu, 15 Jul 2021 15:01:29 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: NET_DSA_MV88E6XXX_PTP should
 depend on NET_DSA_MV88E6XXX

On Wed, Jul 14, 2021 at 11:58:12AM +0200, Geert Uytterhoeven wrote:
> Making global2 support mandatory removed the Kconfig symbol
> NET_DSA_MV88E6XXX_GLOBAL2.  This symbol also served as an intermediate
> symbol to make NET_DSA_MV88E6XXX_PTP depend on NET_DSA_MV88E6XXX.  With
> the symbol removed, the user is always asked about PTP support for
> Marvell 88E6xxx switches, even if the latter support is not enabled.
> 
> Fix this by reinstating the dependency.
> 
> Fixes: 63368a7416df144b ("net: dsa: mv88e6xxx: Make global2 support mandatory")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>