linux-kernel - Re: [PATCH v14 061/138] mm/migrate: Add folio_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C1FDD422-A899-4111-B019-75B0A6D2979A@nvidia.com>
Date:   Thu, 15 Jul 2021 11:55:30 -0400
From:   Zi Yan <ziy@...dia.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v14 061/138] mm/migrate: Add folio_migrate_flags()

On 14 Jul 2021, at 23:35, Matthew Wilcox (Oracle) wrote:

> Turn migrate_page_states() into a wrapper around folio_migrate_flags().
> Also convert two functions only called from folio_migrate_flags() to
> be folio-based.  ksm_migrate_page() becomes folio_migrate_ksm() and
> copy_page_owner() becomes folio_copy_owner().  folio_migrate_flags()
> alone shrinks by two thirds -- 1967 bytes down to 642 bytes.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>  include/linux/ksm.h        |  4 +-
>  include/linux/migrate.h    |  1 +
>  include/linux/page_owner.h |  8 ++--
>  mm/folio-compat.c          |  6 +++
>  mm/ksm.c                   | 31 ++++++++------
>  mm/migrate.c               | 84 +++++++++++++++++++-------------------
>  mm/page_owner.c            | 10 ++---
>  7 files changed, 77 insertions(+), 67 deletions(-)

LGTM. Reviewed-by: Zi Yan <ziy@...dia.com>

—
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)