linux-kernel - Re: [PATCH 3/4] RDMA/siw: Remove kmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Jul 2021 15:00:36 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     ira.weiny@...el.com
Cc:     Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Doug Ledford <dledford@...hat.com>,
        Faisal Latif <faisal.latif@...el.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Bernard Metzler <bmt@...ich.ibm.com>,
        Kamal Heib <kheib@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] RDMA/siw: Remove kmap()

On Mon, Jun 21, 2021 at 11:14:21PM -0700, ira.weiny@...el.com wrote:
> From: Ira Weiny <ira.weiny@...el.com>
> 
> kmap() is being deprecated and will break uses of device dax after PKS
> protection is introduced.[1]
> 
> These uses of kmap() in the SIW driver are thread local.  Therefore
> kmap_local_page() is sufficient to use and will work with pgmap
> protected pages when those are implemnted.
> 
> There is one more use of kmap() in this driver which is split into its
> own patch because kmap_local_page() has strict ordering rules and the
> use of the kmap_mask over multiple segments must be handled carefully.
> Therefore, that conversion is handled in a stand alone patch.
> 
> Use kmap_local_page() instead of kmap() in the 'easy' cases.
> 
> [1] https://lore.kernel.org/lkml/20201009195033.3208459-59-ira.weiny@intel.com/
> 
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> ---
>  drivers/infiniband/sw/siw/siw_qp_tx.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Applied to for-next, thanks

Jason