linux-kernel - Re: [PATCH -V10 3/9] mm/migrate: enable returning precise migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ACF5FE3A-FD50-4BFF-899D-B1AA3B02F83F@nvidia.com>
Date:   Thu, 15 Jul 2021 14:02:48 -0400
From:   Zi Yan <ziy@...dia.com>
To:     Huang Ying <ying.huang@...el.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Yang Shi <yang.shi@...ux.alibaba.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        osalvador <osalvador@...e.de>, Yang Shi <shy828301@...il.com>,
        Michal Hocko <mhocko@...e.com>, Wei Xu <weixugc@...gle.com>,
        Dan Williams <dan.j.williams@...el.com>,
        David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH -V10 3/9] mm/migrate: enable returning precise migrate_pages() success count

On 15 Jul 2021, at 1:51, Huang Ying wrote:

> From: Yang Shi <yang.shi@...ux.alibaba.com>
>
> Under normal circumstances, migrate_pages() returns the number of
> pages migrated.  In error conditions, it returns an error code.  When
> returning an error code, there is no way to know how many pages were
> migrated or not migrated.
>
> Make migrate_pages() return how many pages are demoted successfully
> for all cases, including when encountering errors.  Page reclaim
> behavior will depend on this in subsequent patches.
>
> Signed-off-by: Yang Shi <yang.shi@...ux.alibaba.com>
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
> Suggested-by: osalvador <osalvador@...e.de> [optional parameter]
> Reviewed-by: Yang Shi <shy828301@...il.com>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Wei Xu <weixugc@...gle.com>
> Cc: Zi Yan <ziy@...dia.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: David Hildenbrand <david@...hat.com>
>
> --
>
> Note: Yang Shi originally wrote the patch, thus the SoB.  There was
> also a Reviewed-by provided since there were some modifications made
> to this after the original work.
>
> Changes since 20210618:
>  * Reword some bits of the changelog/subject
>  * Allow callers to pass a NULL 'ret_succeeded'.  This ensures that
>    callers don't have to declare and pass a dummy variable.
>
> Changes since 20210302:
>  * Fix definition of CONFIG_MIGRATION=n stub migrate_pages().  Its
>    parameters were wrong, but oddly enough did not generate any
>    compile errors.
>
> Changes since 20200122:
>  * Fix migrate_pages() to manipulate nr_succeeded *value*
>    rather than the pointer.
> ---
>  include/linux/migrate.h |  5 +++--
>  mm/compaction.c         |  2 +-
>  mm/gup.c                |  2 +-
>  mm/memory-failure.c     |  2 +-
>  mm/memory_hotplug.c     |  2 +-
>  mm/mempolicy.c          |  4 ++--
>  mm/migrate.c            | 11 ++++++++---
>  mm/page_alloc.c         |  2 +-
>  8 files changed, 18 insertions(+), 12 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@...dia.com>

—
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)