linux-kernel - Re: [PATCH v1 2/2] bus: mhi: core: Depict serial number in hexadecimals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210716054021.GB3323@workstation>
Date:   Fri, 16 Jul 2021 11:10:21 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Bhaumik Bhatt <bbhatt@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, hemantk@...eaurora.org,
        quic_jhugo@...cinc.com, linux-kernel@...r.kernel.org,
        loic.poulain@...aro.org
Subject: Re: [PATCH v1 2/2] bus: mhi: core: Depict serial number in
 hexadecimals

On Thu, Jul 15, 2021 at 05:27:56PM -0700, Bhaumik Bhatt wrote:
> In order to maintain consistency with the way OEM PK hash is
> displayed and improve the current way, depict serial number in
> upper case hexadecimals.
> 
> Signed-off-by: Bhaumik Bhatt <bbhatt@...eaurora.org>

Just a minor nit, other than that:

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 8b4336e..d825a06 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev,
>  	struct mhi_device *mhi_dev = to_mhi_device(dev);
>  	struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
>  
> -	return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n",
> +	return snprintf(buf, PAGE_SIZE, "Serial Number: 0x%X\n",

nit: please use "0x%x"

>  			mhi_cntrl->serial_number);
>  }
>  static DEVICE_ATTR_RO(serial_number);
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>