linux-kernel - Re: [PATCH v5 1/2] iio: frequency: adrf6780: add support for ADRF6780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202107161419.uMv6cmWc-lkp@intel.com>
Date:   Fri, 16 Jul 2021 14:13:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Antoniu Miclaus <antoniu.miclaus@...log.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        jic23@...nel.org, devicetree@...r.kernel.org
Cc:     clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        Antoniu Miclaus <antoniu.miclaus@...log.com>
Subject: Re: [PATCH v5 1/2] iio: frequency: adrf6780: add support for ADRF6780

Hi Antoniu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on iio/togreg]
[also build test WARNING on linux/master linus/master v5.14-rc1 next-20210715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Antoniu-Miclaus/iio-frequency-adrf6780-add-support-for-ADRF6780/20210715-194501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: arm64-randconfig-r026-20210716 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/50ec72e90468dea68ad72e14023fdf58d5eb0885
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Antoniu-Miclaus/iio-frequency-adrf6780-add-support-for-ADRF6780/20210715-194501
        git checkout 50ec72e90468dea68ad72e14023fdf58d5eb0885
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/iio/frequency/adrf6780.c:189:40: warning: variable 'data' is uninitialized when used here [-Wuninitialized]
                   ret = adrf6780_read_voltage_raw(dev, data);
                                                        ^~~~
   drivers/iio/frequency/adrf6780.c:184:19: note: initialize the variable 'data' to silence this warning
           unsigned int data;
                            ^
                             = 0
   1 warning generated.


vim +/data +189 drivers/iio/frequency/adrf6780.c

   178	
   179	static int adrf6780_read_raw(struct iio_dev *indio_dev,
   180				    struct iio_chan_spec const *chan,
   181				    int *val, int *val2, long info)
   182	{
   183		struct adrf6780_dev *dev = iio_priv(indio_dev);
   184		unsigned int data;
   185		int ret;
   186	
   187		switch (info) {
   188		case IIO_CHAN_INFO_RAW:
 > 189			ret = adrf6780_read_voltage_raw(dev, data);
   190			if (ret)
   191				return ret;
   192	
   193			*val = data & ADRF6780_ADC_VALUE_MSK;
   194	
   195			return IIO_VAL_INT;
   196	
   197		case IIO_CHAN_INFO_SCALE:
   198			ret = adrf6780_spi_read(dev, ADRF6780_REG_LINEARIZE, &data);
   199			if (ret)
   200				return ret;
   201	
   202			*val = data & ADRF6780_RDAC_LINEARIZE_MSK;
   203	
   204			return IIO_VAL_INT;
   205		case IIO_CHAN_INFO_PHASE:
   206			ret = adrf6780_spi_read(dev, ADRF6780_REG_LO_PATH, &data);
   207			if (ret)
   208				return ret;
   209	
   210			switch (chan->channel2) {
   211			case IIO_MOD_I:
   212				*val = data & ADRF6780_I_PATH_PHASE_ACCURACY_MSK;
   213	
   214				return IIO_VAL_INT;
   215			case IIO_MOD_Q:
   216				*val = FIELD_GET(ADRF6780_Q_PATH_PHASE_ACCURACY_MSK, data);
   217	
   218				return IIO_VAL_INT;
   219			default:
   220				return -EINVAL;
   221			}
   222		default:
   223			return -EINVAL;
   224		}
   225	}
   226	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36366 bytes)