linux-kernel - Re: [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Jul 2021 17:35:38 -0700
From:   Bhaumik Bhatt <bbhatt@...eaurora.org>
To:     Hemant Kumar <hemantk@...eaurora.org>,
        Paul Davey <paul.davey@...iedtelesis.co.nz>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        hemantk=codeaurora.org@...eaurora.org
Subject: Re: [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness

Hi Paul,

On 2021-06-30 06:52 PM, Hemant Kumar wrote:
> Hi Paul,
> On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote:
>> The MHI driver does not work on big endian architectures.  The
>> controller never transitions into mission mode.  This appears to be
>> due
>> to the modem device expecting the various contexts and transfer rings
>> to
>> have fields in little endian order in memory, but the driver
>> constructs
>> them in native endianness.
>> 
>> Fix MHI event, channel and command contexts and TRE handling macros
>> to
>> use explicit conversion to little endian.  Mark fields in relevant
>> structures as little endian to document this requirement.
>> 
>> Signed-off-by: Paul Davey <paul.davey@...iedtelesis.co.nz>
>> ---
>> Removed Tested-by as patch has changed somewhat from v2.
> Bhaumik is going to help testing V2 on x86 platform. Change looks good
> to me. Will ack it once testing is done.
>>  [..]
>> 
> 
> Thanks,
> Hemant

Just following up on this one. I have been seeing problems with my setup 
and
will try to get to this test next week.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project