linux-kernel - Re: [PATCH v3] mm/page_alloc: Require pahole v1.22 to cope with zero-sized struct pagesets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210716080730.GU3809@techsingularity.net>
Date:   Fri, 16 Jul 2021 09:07:30 +0100
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Michal Such?nek <msuchanek@...e.de>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Hellwig <hch@...radead.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Hritik Vijay <hritikxx8@...il.com>,
        Linux-BPF <bpf@...r.kernel.org>,
        Linux-Net <netdev@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>, clm@...com
Subject: Re: [PATCH v3] mm/page_alloc: Require pahole v1.22 to cope with
 zero-sized struct pagesets

On Thu, Jul 15, 2021 at 09:44:53PM +0200, Michal Such?nek wrote:
> > > Well, luckily it seems we anticipated issues like that and added
> > > --skip_encoding_btf_vars argument, which I completely forgot about and
> > > just accidentally came across reviewing Arnaldo's latest pahole patch.
> > > I think that one is a much better solution, as then it will impact
> > > only those that explicitly relies on availability of BTF for per-CPU
> > > variables, which is a subset of all possible uses for kernel BTF. Sent
> > > a patch ([0]), please take a look.
> > > 
> > >   [0] https://lore.kernel.org/linux-mm/20210530002536.3193829-1-andrii@kernel.org/T/#u
> > 
> > I'm happy to have this patch used as an alternative to forcing 1.22 to
> > be the minimum version of pahole required.
> 
> Is pahole 1.22 available already?
> 

Ultimately it was of less importance because of a0b8200d06ad ("kbuild:
skip per-CPU BTF generation for pahole v1.18-v1.21"). As I write this,
pahole v1.22 has not been tagged.

-- 
Mel Gorman
SUSE Labs