linux-kernel - Re: [PATCH v2 7/9] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9c4613fffc80b3102ebb2df6d92cb3af1cd704c8.camel@mediatek.com>
Date:   Fri, 16 Jul 2021 16:15:14 +0800
From:   Jason-JH Lin <jason-jh.lin@...iatek.com>
To:     Chun-Kuang Hu <chunkuang.hu@...nel.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        <fshao@...gle.com>, Nancy Lin <nancy.lin@...iatek.com>,
        <singo.chang@...iatek.com>
Subject: Re: [PATCH v2 7/9] drm/mediatek: add mediatek-drm of vdosys0
 support for mt8195

On Wed, 2021-07-14 at 22:35 +0800, Chun-Kuang Hu wrote:
> Hi, Jason:
> 
> jason-jh.lin <jason-jh.lin@...iatek.com> 於 2021年7月10日 週六 下午7:38寫道：
> > 
> > Add driver data of mt8195 vdosys0 to mediatek-drm and the sub
> > driver.
> > 
> > Signed-off-by: jason-jh.lin <jason-jh.lin@...iatek.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_disp_rdma.c |  6 ++++++
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c   | 24
> > ++++++++++++++++++++++++
> >  2 files changed, 30 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > index 728aaadfea8c..00e9827acefe 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > @@ -355,6 +355,10 @@ static const struct mtk_disp_rdma_data
> > mt8183_rdma_driver_data = {
> >         .fifo_size = 5 * SZ_1K,
> >  };
> > 
> > +static const struct mtk_disp_rdma_data mt8195_rdma_driver_data = {
> > +       .fifo_size = 1920,
> > +};
> > +
> >  static const struct of_device_id mtk_disp_rdma_driver_dt_match[] =
> > {
> >         { .compatible = "mediatek,mt2701-disp-rdma",
> >           .data = &mt2701_rdma_driver_data},
> > @@ -362,6 +366,8 @@ static const struct of_device_id
> > mtk_disp_rdma_driver_dt_match[] = {
> >           .data = &mt8173_rdma_driver_data},
> >         { .compatible = "mediatek,mt8183-disp-rdma",
> >           .data = &mt8183_rdma_driver_data},
> > +       { .compatible = "mediatek,mt8195-disp-rdma",
> > +         .data = &mt8195_rdma_driver_data},
> >         {},
> >  };
> >  MODULE_DEVICE_TABLE(of, mtk_disp_rdma_driver_dt_match);
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index b46bdb8985da..d6f6d1bdad85 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -147,6 +147,19 @@ static const enum mtk_ddp_comp_id
> > mt8183_mtk_ddp_ext[] = {
> >         DDP_COMPONENT_DPI0,
> >  };
> > 
> > +static const enum mtk_ddp_comp_id mt8195_mtk_ddp_main[] = {
> > +       DDP_COMPONENT_OVL0,
> > +       DDP_COMPONENT_RDMA0,
> > +       DDP_COMPONENT_COLOR0,
> > +       DDP_COMPONENT_CCORR,
> > +       DDP_COMPONENT_AAL0,
> > +       DDP_COMPONENT_GAMMA,
> > +       DDP_COMPONENT_DITHER,
> > +       DDP_COMPONENT_DSC0,
> > +       DDP_COMPONENT_MERGE0,
> > +       DDP_COMPONENT_DP_INTF0,
> 
> Where is the dp_intf driver in this series?
> 
> Regards,
> Chun-Kuang.
> 
Hi CK,

dp_intf driver will be upstream in another series patches by DP owner.

Regards,
Jason-JH.Lin

> > +};
> > +
> >  static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data
> > = {
> >         .main_path = mt2701_mtk_ddp_main,
> >         .main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
> > @@ -186,6 +199,11 @@ static const struct mtk_mmsys_driver_data
> > mt8183_mmsys_driver_data = {
> >         .ext_len = ARRAY_SIZE(mt8183_mtk_ddp_ext),
> >  };
> > 
> > +static const struct mtk_mmsys_driver_data
> > mt8195_vdosys0_driver_data = {
> > +       .main_path = mt8195_mtk_ddp_main,
> > +       .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main),
> > +};
> > +
> >  static int mtk_drm_kms_init(struct drm_device *drm)
> >  {
> >         struct mtk_drm_private *private = drm->dev_private;
> > @@ -410,6 +428,8 @@ static const struct of_device_id
> > mtk_ddp_comp_dt_ids[] = {
> >           .data = (void *)MTK_DISP_RDMA },
> >         { .compatible = "mediatek,mt8183-disp-rdma",
> >           .data = (void *)MTK_DISP_RDMA },
> > +       { .compatible = "mediatek,mt8195-disp-rdma",
> > +         .data = (void *)MTK_DISP_RDMA },
> >         { .compatible = "mediatek,mt8173-disp-wdma",
> >           .data = (void *)MTK_DISP_WDMA },
> >         { .compatible = "mediatek,mt8183-disp-ccorr",
> > @@ -448,6 +468,8 @@ static const struct of_device_id
> > mtk_ddp_comp_dt_ids[] = {
> >           .data = (void *)MTK_DISP_MUTEX },
> >         { .compatible = "mediatek,mt8183-disp-mutex",
> >           .data = (void *)MTK_DISP_MUTEX },
> > +       { .compatible = "mediatek,mt8195-disp-mutex",
> > +         .data = (void *)MTK_DISP_MUTEX },
> >         { .compatible = "mediatek,mt2701-disp-pwm",
> >           .data = (void *)MTK_DISP_BLS },
> >         { .compatible = "mediatek,mt8173-disp-pwm",
> > @@ -468,6 +490,8 @@ static const struct of_device_id
> > mtk_drm_of_ids[] = {
> >           .data = &mt8173_mmsys_driver_data},
> >         { .compatible = "mediatek,mt8183-mmsys",
> >           .data = &mt8183_mmsys_driver_data},
> > +       {.compatible = "mediatek,mt8195-vdosys0",
> > +         .data = &mt8195_vdosys0_driver_data},
> >         { }
> >  };
> >  MODULE_DEVICE_TABLE(of, mtk_drm_of_ids);
> > --
> > 2.18.0
> > 
-- 
Jason-JH Lin <jason-jh.lin@...iatek.com>