linux-kernel - Re: [PATCH v2] usb: typec: tipd: Don't block probing of consumer of "connector" nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Jul 2021 12:56:31 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     saravanak@...gle.com, grandmaster@...klimov.de,
        gregkh@...uxfoundation.org, rjw@...ysocki.net, kernel@...i.sm,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] usb: typec: tipd: Don't block probing of consumer of
 "connector" nodes

Wed, Jul 14, 2021 at 08:18:07AM +0200, Martin Kepplinger kirjoitti:
> Similar as with tcpm this patch lets fw_devlink know not to wait on the
> fwnode to be populated as a struct device.
> 
> Without this patch, USB functionality can be broken on some previously
> supported boards.
> 
> Fixes: 28ec344bb891 ("usb: typec: tcpm: Don't block probing of consumers of "connector" nodes")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
> 
> revision history
> ----------------
> v2: (thank you Saravana)
> * add a code-comment why the call is needed.
> 
> v1:
> https://lore.kernel.org/linux-usb/20210713073946.102501-1-martin.kepplinger@puri.sm/
> 
> 
> 
>  drivers/usb/typec/tipd/core.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 938219bc1b4b..21b3ae25c76d 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -629,6 +629,15 @@ static int tps6598x_probe(struct i2c_client *client)
>  	if (!fwnode)
>  		return -ENODEV;
>  
> +	/*
> +	 * This fwnode has a "compatible" property, but is never populated as a
> +	 * struct device. Instead we simply parse it to read the properties.
> +	 * This breaks fw_devlink=on. To maintain backward compatibility
> +	 * with existing DT files, we work around this by deleting any
> +	 * fwnode_links to/from this fwnode.
> +	 */
> +	fw_devlink_purge_absent_suppliers(fwnode);
> +
>  	tps->role_sw = fwnode_usb_role_switch_get(fwnode);
>  	if (IS_ERR(tps->role_sw)) {
>  		ret = PTR_ERR(tps->role_sw);
> -- 
> 2.30.2

-- 
heikki