linux-kernel - Re: [PATCH] mm/secretmem: wire up ->set_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8977f73-d7eb-9a81-4667-ad9302130200@redhat.com>
Date:   Fri, 16 Jul 2021 12:05:43 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Mike Rapoport <rppt@...ux.ibm.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/secretmem: wire up ->set_page_dirty

On 16.07.21 08:39, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@...ux.ibm.com>
> 
> Make secretmem up to date with the changes done in commit 0af573780b0b
> ("mm: require ->set_page_dirty to be explicitly wired up") so that
> unconditional call to this method won't cause crashes.
> 
> Fixes: 0af573780b0b ("mm: require ->set_page_dirty to be explicitly wired up")
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
> ---
>   mm/secretmem.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index f77d25467a14..030f02ddc7c1 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -152,6 +152,7 @@ static void secretmem_freepage(struct page *page)
>   }
>   
>   const struct address_space_operations secretmem_aops = {
> +	.set_page_dirty	= __set_page_dirty_no_writeback,
>   	.freepage	= secretmem_freepage,
>   	.migratepage	= secretmem_migratepage,
>   	.isolate_page	= secretmem_isolate_page,
> 
> base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb