linux-kernel - Re: [PATCH 3/3] mm/vmstat: remove unneeded return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9598b11-486f-f047-63ca-ba6a6e1de3e4@redhat.com>
Date:   Fri, 16 Jul 2021 14:59:14 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] mm/vmstat: remove unneeded return value

On 15.07.21 14:29, Miaohe Lin wrote:
> The return value of pagetypeinfo_showfree and pagetypeinfo_showblockcount
> are unused now. Remove them.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>   mm/vmstat.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 76aef9510f6d..6246bab9fae2 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -1452,7 +1452,7 @@ static void pagetypeinfo_showfree_print(struct seq_file *m,
>   }
>   
>   /* Print out the free pages at each order for each migatetype */
> -static int pagetypeinfo_showfree(struct seq_file *m, void *arg)
> +static void pagetypeinfo_showfree(struct seq_file *m, void *arg)
>   {
>   	int order;
>   	pg_data_t *pgdat = (pg_data_t *)arg;
> @@ -1464,8 +1464,6 @@ static int pagetypeinfo_showfree(struct seq_file *m, void *arg)
>   	seq_putc(m, '\n');
>   
>   	walk_zones_in_node(m, pgdat, true, false, pagetypeinfo_showfree_print);
> -
> -	return 0;
>   }
>   
>   static void pagetypeinfo_showblockcount_print(struct seq_file *m,
> @@ -1501,7 +1499,7 @@ static void pagetypeinfo_showblockcount_print(struct seq_file *m,
>   }
>   
>   /* Print out the number of pageblocks for each migratetype */
> -static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
> +static void pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
>   {
>   	int mtype;
>   	pg_data_t *pgdat = (pg_data_t *)arg;
> @@ -1512,8 +1510,6 @@ static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
>   	seq_putc(m, '\n');
>   	walk_zones_in_node(m, pgdat, true, false,
>   		pagetypeinfo_showblockcount_print);
> -
> -	return 0;
>   }
>   
>   /*
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb