linux-kernel - Re: [PATCH v5 3/3] power: supply: mt6360

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210716134843.w7cl7ekkm3dm6pu5@earth.universe>
Date:   Fri, 16 Jul 2021 15:48:43 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Gene Chen <gene.chen.richtek@...il.com>
Cc:     "Vaittinen, Matti" <matti.vaittinen@...rohmeurope.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>, inux-pm@...r.kernel.org,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Gene Chen <gene_chen@...htek.com>, Wilma.Wu@...iatek.com,
        shufan_lee@...htek.com, ChiYuan Huang <cy_huang@...htek.com>,
        benjamin.chao@...iatek.com
Subject: Re: [PATCH v5 3/3] power: supply: mt6360_charger: add MT6360 charger
 support

Hi,

On Mon, May 31, 2021 at 11:39:50AM +0800, Gene Chen wrote:
> > > +static int mt6360_charger_remove(struct platform_device *pdev)
> > > +{
> > > +     struct mt6360_chg_info *mci = platform_get_drvdata(pdev);
> > > +
> > > +     cancel_work_sync(&mci->chrdet_work);
> > > +
> > > +     return 0;
> > > +}
> >
> > Just as a note, devm_work_autocancel() should hopefully be included at
> > next cycle. Then you might be able to drop the .remove().
> 
> ACK, I will replace it, thanks.

> > FWIW:
> > Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

Did I miss a newer revision?

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)