linux-kernel - Re: [PATCH v7 1/2] power: supply: PCHG: Peripheral device charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210716135725.d3fadbozpmigmzmp@earth.universe>
Date:   Fri, 16 Jul 2021 15:57:25 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Daisuke Nojiri <dnojiri@...omium.org>
Cc:     vpalatin@...omium.org, Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Prashant Malani <pmalani@...omium.org>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        Utkarsh Patel <utkarsh.h.patel@...el.com>,
        Yu-Hsuan Hsu <yuhsuan@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v7 1/2] power: supply: PCHG: Peripheral device charger

Hi,

On Wed, Jun 16, 2021 at 11:51:24AM -0700, Daisuke Nojiri wrote:
> This patch adds a driver for PCHG (Peripheral CHarGer). PCHG is a
> framework managing power supplies for peripheral devices.
> 
> This driver creates a sysfs node for each peripheral charge port:
> 
> 	/sys/class/power_supply/peripheral<n>
> 
> where <n> is the index of a charge port.
> 
> For example, when a stylus is connected to a NFC/WLC port, the node
> returns:
> 
> 	/sys/class/power_supply/peripheral0/
> 		capacity=50
> 		charge_type=Standard
> 		scope=Device
> 		status=Charging
> 		type=Battery
> 
> Signed-off-by: Daisuke Nojiri <dnojiri@...omium.org>
> ---
> [...]
> +static enum power_supply_property cros_pchg_props[] = {
> +	POWER_SUPPLY_PROP_STATUS,
> +	POWER_SUPPLY_PROP_CHARGE_TYPE,
> +	POWER_SUPPLY_PROP_CAPACITY,
> +	POWER_SUPPLY_PROP_SCOPE,
> +	/*
> +	 * todo: Add the following.
> +	 *
> +	 * POWER_SUPPLY_PROP_TECHNOLOGY,
> +	 * POWER_SUPPLY_PROP_ERROR,
> +	 * POWER_SUPPLY_PROP_SERIAL_NUMBER,
> +	 *
> +	 * POWER_SUPPLY_PROP_ONLINE can't be used because it indicates the
> +	 * system is powered by AC.
> +	 */
> +};
> [...]

Thanks, I queued the driver with the above TODO removed. Please
track this downstream, the note is not useful in mainline kernel,
since we do not have (AFAIK) the necessary documentation to add
more features.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)