linux-kernel - Re: [PATCH v13 1/9] staging: hi6421-spmi-pmic: rename GPIO IRQ OF node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210716164529.35d3cb0c@coco.lan>
Date:   Fri, 16 Jul 2021 16:45:29 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linuxarm <linuxarm@...wei.com>, mauro.chehab@...wei.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v13 1/9] staging: hi6421-spmi-pmic: rename GPIO IRQ OF
 node

Em Wed, 14 Jul 2021 07:36:43 -0600
Rob Herring <robh@...nel.org> escreveu:

> On Wed, Jul 14, 2021 at 3:13 AM Mauro Carvalho Chehab
> <mchehab+huawei@...nel.org> wrote:
> >
> > Instead of using the standard name ("gpios"), use "interrupts".
> >
> > Suggested-by: Rob Herring <robh@...nel.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > ---
> >  drivers/staging/hikey9xx/hi6421-spmi-pmic.c              | 2 +-
> >  drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> > index 35ef3d4c760b..9a7e095246f7 100644
> > --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> > +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> > @@ -233,7 +233,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
> >
> >         ddata->dev = dev;
> >
> > -       ddata->gpio = of_get_gpio(np, 0);
> > +       ddata->gpio = of_get_named_gpio_flags(np, "interrupts", 0, NULL);  
> 
> It's an interrupt, you should be using platform_get_irq() and
> devm_request_irq().
> 
> In general, you should not be using of_get_* for any resources, but
> use the firmware agnostic flavors.

I've no idea how to convert to use platform_get_irq().

I tried to replace the logic:

	priv->gpio = of_get_gpio(np, 0);
	if (priv->gpio < 0)
		return priv->gpio;

	if (!gpio_is_valid(priv->gpio))
		return -EINVAL;

	ret = devm_gpio_request_one(dev, priv->gpio, GPIOF_IN, "pmic");
	if (ret < 0) {
		dev_err(dev, "Failed to request gpio%d\n", priv->gpio);
		return ret;
	}

Into:

	priv->irq = platform_get_irq(pdev, 0);

But it didn't work (I also tried the platform_get_irq_byname):

	[    1.109586] hi6421v600-irq hi6421v600-irq: hi6421v600_irq_probe:
	[    1.115676] hi6421v600-irq hi6421v600-irq: IRQ index 0 not found
	[    1.121751] hi6421v600-irq hi6421v600-irq: Error -6 when getting IRQs

The original DT schema as:

	gpios = <&gpio28 0 0>;

Based on your past review, this was replaced by:

	interrupts = <&gpio28 0 0>;


What am I missing?

Thanks,
Mauro