linux-kernel - Re: [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPGs5qGih6R9DFWG@piout.net>
Date:   Fri, 16 Jul 2021 17:59:34 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Tudor Ambarus <tudor.ambarus@...rochip.com>
Cc:     nicolas.ferre@...rochip.com, ludovic.desroches@...rochip.com,
        claudiu.beznea@...rochip.com, eugen.hristev@...rochip.com,
        codrin.ciubotariu@...rochip.com, emil.velikov@...labora.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig
 and clean leftovers

On 16/07/2021 18:14:46+0300, Tudor Ambarus wrote:
> Even since the addition CONFIG_VIDEO_HANTRO was set to n because
> it did not respect the dependency chain. It doesn't respect it now
> either, remove it.
> 

Shouldn't you rather ensure it is enabled so we get it for sama5d4?

> Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
> ---
>  arch/arm/configs/sama5_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
> index 17db3b3e2dd3..1ccf84091dd7 100644
> --- a/arch/arm/configs/sama5_defconfig
> +++ b/arch/arm/configs/sama5_defconfig
> @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y
>  CONFIG_AT_XDMAC=y
>  CONFIG_STAGING=y
>  CONFIG_STAGING_MEDIA=y
> -CONFIG_VIDEO_HANTRO=m
>  # CONFIG_IOMMU_SUPPORT is not set
>  CONFIG_IIO=y
>  CONFIG_AT91_ADC=y
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com