linux-kernel - Re: [PATCH v3] workqueue: fix UAF in pwq_unbound_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YPGwZVsE0AmkpziS@mtj.duckdns.org>
Date:   Fri, 16 Jul 2021 06:14:29 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, jiangshanlai@...il.com,
        xuqiang36@...wei.com, paskripkin@...il.com
Subject: Re: [PATCH v3] workqueue: fix UAF in pwq_unbound_release_workfn()

On Wed, Jul 14, 2021 at 05:19:33PM +0800, Yang Yingliang wrote:
> If apply_wqattrs_prepare() fails, the new pwq are not linked, it doesn't
> hold any reference to the 'wq', 'wq' is invalid to access in the worker,
> so add check pwq if linked to fix this.
> 
> Fixes: 2d5f0764b526 ("workqueue: split apply_workqueue_attrs() into 3 stages")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Suggested-by: Lai Jiangshan <jiangshanlai@...il.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Applied to wq/for-5.14-fixes.

Thanks.

-- 
tejun