linux-kernel - Re: [PATCH] efi/libstub: Fix the efi_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFVj8RFxy5Ujio7Ah6=HFOhNtHVWiCiPKzzQUF4ahY=xw@mail.gmail.com>
Date:   Fri, 16 Jul 2021 18:18:43 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Atish Patra <atish.patra@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        linux-efi <linux-efi@...r.kernel.org>,
        Will Deacon <will@...nel.org>,
        Heinrich Schuchardt <xypron.glpk@....de>
Subject: Re: [PATCH] efi/libstub: Fix the efi_load_initrd function description

On Fri, 2 Jul 2021 at 21:10, Atish Patra <atish.patra@....com> wrote:
>
> The soft_limit and hard_limit in the function efi_load_initrd describes
> the preferred and max address of initrd loading location respectively.
> However, the description wrongly describes it as the size of the
> allocated memory.
>
> Fix the function description.
>
> Signed-off-by: Atish Patra <atish.patra@....com>

Now queued up, thanks.

> ---
>  drivers/firmware/efi/libstub/efi-stub-helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
> index aa8da0a49829..ae87dded989d 100644
> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c
> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
> @@ -630,8 +630,8 @@ efi_status_t efi_load_initrd_cmdline(efi_loaded_image_t *image,
>   * @image:     EFI loaded image protocol
>   * @load_addr: pointer to loaded initrd
>   * @load_size: size of loaded initrd
> - * @soft_limit:        preferred size of allocated memory for loading the initrd
> - * @hard_limit:        minimum size of allocated memory
> + * @soft_limit:        preferred address for loading the initrd
> + * @hard_limit:        upper limit address for loading the initrd
>   *
>   * Return:     status code
>   */
> --
> 2.31.1
>