linux-kernel - Re: [PATCH 5.13 252/266] media: rtl28xxu: fix zero-length control request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPHI9iIUnBFchvmq@kroah.com>
Date:   Fri, 16 Jul 2021 19:59:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        syzbot+faf11bbadc5a372564da@...kaller.appspotmail.com,
        Antti Palosaari <crope@....fi>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH 5.13 252/266] media: rtl28xxu: fix zero-length control
 request

On Fri, Jul 16, 2021 at 09:54:49AM +0200, Johan Hovold wrote:
> On Thu, Jul 15, 2021 at 08:40:07PM +0200, Greg Kroah-Hartman wrote:
> > From: Johan Hovold <johan@...nel.org>
> > 
> > commit 25d5ce3a606a1eb23a9265d615a92a876ff9cb5f upstream.
> > 
> > The direction of the pipe argument must match the request-type direction
> > bit or control requests may fail depending on the host-controller-driver
> > implementation.
> > 
> > Control transfers without a data stage are treated as OUT requests by
> > the USB stack and should be using usb_sndctrlpipe(). Failing to do so
> > will now trigger a warning.
> > 
> > Fix the zero-length i2c-read request used for type detection by
> > attempting to read a single byte instead.
> > 
> > Reported-by: syzbot+faf11bbadc5a372564da@...kaller.appspotmail.com
> > Fixes: d0f232e823af ("[media] rtl28xxu: add heuristic to detect chip type")
> > Cc: stable@...r.kernel.org      # 4.0
> > Cc: Antti Palosaari <crope@....fi>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > Signed-off-by: Hans Verkuil <hverkuil-cisco@...all.nl>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Please drop this patch from all stable trees. 
> 
> This patch causes a regression and a second version was sent almost two
> months ago, but I'm not getting any response whatsoever from the media
> maintainers. 
> 
> I resent the correct fix and a revert of this one almost a month ago and
> the cover letter includes some further details:
> 
> 	https://lore.kernel.org/r/20210623084521.7105-1-johan@kernel.org
> 
> But this still hasn't been fixed in linux-next.

Now dropped from all stable queues, thanks.

greg k-h