linux-kernel - Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Jul 2021 18:50:04 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Ilias Apalodimas <ilias.apalodimas@...aro.org>
Cc:     netdev@...r.kernel.org, linyunsheng@...wei.com,
        alexanderduyck@...com, brouer@...hat.com, davem@...emloft.net,
        kuba@...nel.org, alobakin@...me, jonathan.lemon@...il.com,
        willemb@...gle.com, linmiaohe@...wei.com, gnault@...hat.com,
        cong.wang@...edance.com, mcroce@...rosoft.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 v3] skbuff: Fix a potential race while recycling page_pool
 packets

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 16 Jul 2021 10:02:18 +0300 you wrote:
> As Alexander points out, when we are trying to recycle a cloned/expanded
> SKB we might trigger a race.  The recycling code relies on the
> pp_recycle bit to trigger,  which we carry over to cloned SKBs.
> If that cloned SKB gets expanded or if we get references to the frags,
> call skb_release_data() and overwrite skb->head, we are creating separate
> instances accessing the same page frags.  Since the skb_release_data()
> will first try to recycle the frags,  there's a potential race between
> the original and cloned SKB, since both will have the pp_recycle bit set.
> 
> [...]

Here is the summary with links:
  - [1/1,v3] skbuff: Fix a potential race while recycling page_pool packets
    https://git.kernel.org/netdev/net/c/2cc3aeb5eccc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html