Date:   Sat, 17 Jul 2021 17:05:01 +0800
From:   Kewei Xu <kewei.xu@...iatek.com>
To:     Chen-Yu Tsai <wenst@...omium.org>
CC:     "wsa@...-dreams.de" <wsa@...-dreams.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        srv_heupstream <srv_heupstream@...iatek.com>,
        Leilk Liu (刘磊) 
        <Leilk.Liu@...iatek.com>,
        Qii Wang (王琪) 
        <Qii.Wang@...iatek.com>,
        Qiangming Xia (夏强明) 
        <Qiangming.Xia@...iatek.com>,
        Daolong Zhu (祝道龙) 
        <ot_daolong.zhu@...iatek.com>
Subject: Re: [PATCH 0/8] Due to changes in hardware design, add patch to

On Thu, 2021-07-15 at 11:03 +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Thu, Jul 15, 2021 at 10:37 AM Kewei Xu <kewei.xu@...iatek.com> wrote:
> >
> > 1. In order to facilitate the review, the two series of patches submitted
> >    before have been integrated together.
> 
> I'm not sure that really helps. We'll see.
> 
> > 2. Resubmit a patch to fixing the incorrect register value.
> 
> Fixes can be submitted separately, or at the very least, put at the very
> front of the series.
> 
> > 3. Add modify bus speed calculation formula patch
> 
> When resubmitting patch series, please add appropriate versioning and
> changelogs. This will help maintainers understand that this is a new
> version of the series, and what has changed. This includes times when
> the original patches weren't changed, but additional patches were added.
> 
> Please also keep the original series subject, which IIRC was about adding
> support for MT8195 I2C. The subject you now used should be part of the
> cover letter.
> 
> If you combine different patch series, you should use the highest version
> number + 1.
> 
> 
> Regards
> ChenYu
> 
> >
> > Kewei Xu (8):
> >   dt-bindings: i2c: update bindings for MT8195 SoC
> >   i2c: mediatek: Dump i2c/dma register when a timeout occurs
> >   i2c: mediatek: fixing the incorrect register offset
> >   i2c: mediatek: Reset the handshake signal between i2c and dma
> >   i2c: mediatek: Add OFFSET_EXT_CONF setting back
> >   dt-bindings: i2c: add attribute default-timing-adjust
> >   i2c: mediatek: Isolate speed setting via dts for special devices
> >   i2c: mediatek: modify bus speed calculation formula
> >
> >  .../devicetree/bindings/i2c/i2c-mt65xx.txt         |   3 +
> >  drivers/i2c/busses/i2c-mt65xx.c                    | 229 +++++++++++++++++++--
> >  2 files changed, 217 insertions(+), 15 deletions(-)
> >
> > --
> > 1.9.1
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek

Hi ChenYu,

2. OK, I will place the fixes at the very least in the next patch.

3. I will take your opinion combine different patch series, you should
use the highest version number +1.

I have submitted two different series of patches before. The topics are
"Add i2c support for mt8195" (highest version number: V1) and "Introduce
an attribute to select timing settings" (highest version number:V3).
Later I will combine the above two series of patches and submit V4 with
"Introducing an attribute to select the time setting" as the subject
title.

Thanks

Regards
Kewei
  

Powered by blists - more mailing lists