linux-kernel - Re: [syzbot] possible deadlock in loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77da708c-b63d-dac0-c7e6-43ced0d49982@gmail.com>
Date:   Sat, 17 Jul 2021 17:41:03 +0800
From:   Desmond Cheong Zhi Xi <desmondcheongzx@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Hillf Danton <hdanton@...a.com>
Cc:     Christoph Hellwig <hch@....de>,
        syzbot <syzbot+118992efda475c16dfb0@...kaller.appspotmail.com>,
        axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] possible deadlock in loop_add

On 16/7/21 7:00 am, Miquel Raynal wrote:
> Hello,
> 
> Desmond Cheong Zhi Xi <desmondcheongzx@...il.com> wrote on Mon, 12 Jul
> 2021 16:29:16 +0800:
> 
>> On 12/7/21 1:27 pm, Christoph Hellwig wrote:
>>> On Sat, Jul 10, 2021 at 09:16:38PM +0800, Hillf Danton wrote:
>>>> To break the lock chain, un/register blkdev without mtd_table_mutex held.
>>>
>>> Yes, Desmond Cheong Zhi Xi sent pretty much the same patch on June 18th
>>> (mtd: break circular locks in register_mtd_blktrans), but it did not get
>>> picked up.
>>>    
>>
>> I believe Miquèl was waiting for -rc1 to apply it.
> 
> Indeed, I already applied it but did not advertise yet.
> 

Thanks Miquèl!

>>
>> But taking a closer look, although the fix for the register path is the same, Hillf Danton's proposed patch additionally avoids inverting the lock hierarchy on the unregister path. So I believe this new patch should be more robust.
> 
> We can definitely do this in two steps if you want.
> 

Sounds good, I'll prepare a patch with Hillf's suggestion for the 
unregister path.

> Thanks,
> Miquèl
>