linux-kernel - Re: [PATCH] block: increase BLKCG_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32f6b089-46fa-55ec-ce7c-88da7e224728@kernel.dk>
Date:   Sat, 17 Jul 2021 13:07:09 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Oleksandr Natalenko <oleksandr@...alenko.name>,
        linux-kernel@...r.kernel.org
Cc:     linux-block@...r.kernel.org, Ming Lei <ming.lei@...hat.com>,
        Christoph Hellwig <hch@....de>,
        Laurence Oberman <loberman@...hat.com>,
        Paolo Valente <paolo.valente@...aro.org>,
        David Jeffery <djeffery@...hat.com>,
        Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH] block: increase BLKCG_MAX_POLS

On 7/17/21 6:33 AM, Oleksandr Natalenko wrote:
> After mq-deadline learnt to deal with cgroups, the BLKCG_MAX_POLS value
> became too small for all the elevators to be registered properly. The
> following issue is seen:
> 
> ```
> calling  bfq_init+0x0/0x8b @ 1
> blkcg_policy_register: BLKCG_MAX_POLS too small
> initcall bfq_init+0x0/0x8b returned -28 after 507 usecs
> ```
> 
> and BFQ is non-functional.
> 
> Increase BLKCG_MAX_POLS to allow space for everyone

LGTM, just needs a:

Fixes: 08a9ad8bf607 ("block/mq-deadline: Add cgroup support")

in there too, I'll add it.

-- 
Jens Axboe