linux-kernel - Re: [PATCH 3/3] staging: rtl8723bs: fix camel case issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210717082901.GM1931@kadam>
Date:   Sat, 17 Jul 2021 11:29:01 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     gregkh@...uxfoundation.org, hdegoede@...hat.com,
        Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8723bs: fix camel case issue

On Wed, Jul 14, 2021 at 09:04:57PM +0200, Fabio Aiuto wrote:
> Hello Dan,
> 
> On Wed, Jul 14, 2021 at 06:26:05PM +0300, Dan Carpenter wrote:
> > On Wed, Jul 14, 2021 at 05:11:14PM +0200, Fabio Aiuto wrote:
> > > fix following post commit hook checkpatch issue:
> > > 
> > > CHECK: Avoid CamelCase: <NetType>
> > > 45: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:170:
> > > +#define is_supported_ht(NetType) (((NetType)
> > > 	& (WIRELESS_11_24N)) ? true : false)
> > > 
> > > Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> > > ---
> > >  drivers/staging/rtl8723bs/include/ieee80211.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
> > > index 8eb0557a077a..b2c1a7dafcee 100644
> > > --- a/drivers/staging/rtl8723bs/include/ieee80211.h
> > > +++ b/drivers/staging/rtl8723bs/include/ieee80211.h
> > > @@ -167,7 +167,7 @@ enum network_type {
> > >  
> > >  #define IsSupportedTxCCK(NetType) (((NetType) & (WIRELESS_11B)) ? true : false)
> > >  #define IsSupportedTxOFDM(NetType) (((NetType) & (WIRELESS_11G) ? true : false)
> > 
> > These are the same.
> > 
> > > -#define is_supported_ht(NetType) (((NetType) & (WIRELESS_11_24N)) ? true : false)
> > > +#define is_supported_ht(net_type) (((net_type) & (WIRELESS_11_24N)) ? true : false)
> > >  
> 
> NetType -> net_type, or did you mean something else?

Yes.  If you're going to change it then change the surrounding code as
well.

regards,
dan carpenter