linux-kernel - Re: [PATCH v2] Decouple build from userspace headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATt3tvF9n5LMosirxs50PMQ1RKPp1j1FVAx3yz+uXmvVw@mail.gmail.com>
Date:   Sun, 18 Jul 2021 22:11:41 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Anders Roxell <anders.roxell@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Christoph Hellwig <hch@...radead.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2] Decouple build from userspace headers

On Fri, Jul 16, 2021 at 7:10 PM Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> On Fri, Jul 16, 2021 at 11:03:41AM +0200, Anders Roxell wrote:
> > On Wed, 14 Jul 2021 at 19:45, Alexey Dobriyan <adobriyan@...il.com> wrote:
> > >
>
> > In file included from
> > /home/anders/src/kernel/testing/crypto/aegis128-neon-inner.c:7:
> > /home/anders/src/kernel/testing/arch/arm64/include/asm/neon-intrinsics.h:33:10:
> > fatal error: arm_neon.h: No such file or directory
> >    33 | #include <arm_neon.h>
> >       |          ^~~~~~~~~~~~
>
> > If I revert this patch I can build it.
>
> Please, see followup fixes or grab new -mm.
> https://lore.kernel.org/lkml/YO8ioz4sHwcUAkdt@localhost.localdomain/


With the follow-up fix,
this patch is doing many things in a single patch.

Can you split it into a series of smaller patches?


1/4: changes for arch/um/include/shared/irq_user.h
     and arch/um/os-Linux/signal.c


2/4:  remove wrong <stdbool.h> or <stddef.h> inclusions
      (or maybe you need to replace them with <linux/types.h>
      to keep the affected headers self-contained)


3/4: add include/linux/stdarg.h,
     then <stdarg.h> with <linux/stdarg.h>


4/4: move -isystem $(shell $(CC) -print-file-name=include)
     to some sub-Makefiles from the top Makefile.





(please note 4/4 will introduce a breakage in linux-next
if somebody adds a new <stdarg.h> inclusion in this
development cycle.
I hope that will not happen, though)




--
Best Regards
Masahiro Yamada